usapears: implement redundant-nutrient-value filtering #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…changing its behaviour, yet)
jknndy
approved these changes
Oct 16, 2024
Co-authored-by: Joey <7505194+jknndy@users.noreply.github.com>
|
Thanks @jknndy! |
jayaddison
commented
Oct 17, 2024
| def nutrients(self): | ||
| container = self.soup.find("ul", {"itemprop": "nutrition"}) | ||
| if not container: | ||
| raise ElementNotFoundInHtml("Could not find nutritional info container") |
There was a problem hiding this comment.
I think I'll merge this as-is, but a note about something I realized while self-reviewing my changes: we're a bit inconsistent throughout the codebase about usage of the arguments to the ElementNotFoundInHtml initializer, and what their purpose is. There might be an opportunity to improve the consistency/functionality there in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1289.